Knightly instances are not deleted

So we noticed that the knightly instances are not deleted after they exceeded the limit we set, 5 instances at a time.

added Backlog label

changed the description

It might be because of this. If this is the case, it actually deletes instances, just not a list of instances but only one is deleted.

As of now, we have 12 instances:

6ca8885a-b7b9-4cef-a02d-cbee560a7fbd ood-20230324
dd6eba98-0325-45fc-9674-e1061d7f0ba8 ood-20230323
1c22ac2e-c180-46b9-9179-1c799f03e433 ood-20230322
b467bd39-4058-4b67-9997-6ce1f5dd39d5 ood-20230318
ce9a62e0-fe54-417e-9c51-fbded294ddcf ood-20230316
fffcd1c5-edd2-4dba-ab8a-2ba6e29b62a5 ood-20230310
3f98e4e2-b71e-4617-883b-616b0d3f4870 ood-20230309
4b031299-9d1b-4950-b748-964456d31da4 ood-20230308
f8d98f11-a24c-48d9-baf1-a14ef9ce4590 ood-20230306
3b82817c-6c18-4132-b580-2e6ed1326d3d ood-20230304
8e0d1072-dd22-4e31-a992-bf153a14645a ood-20230303
5069b637-6aaf-418a-87d0-f89f0c30c6ab ood-20230301

Three knightly builds later:

398fc7bf-36e1-4928-bf51-c220db2c5371 ood-20230327
dad953cc-3be2-4d2d-8cac-17f04fd72b78 ood-20230326
d32a0dee-17d5-4a27-92cd-fd160c92be0d ood-20230325
6ca8885a-b7b9-4cef-a02d-cbee560a7fbd ood-20230324
dd6eba98-0325-45fc-9674-e1061d7f0ba8 ood-20230323
fffcd1c5-edd2-4dba-ab8a-2ba6e29b62a5 ood-20230310
3f98e4e2-b71e-4617-883b-616b0d3f4870 ood-20230309
4b031299-9d1b-4950-b748-964456d31da4 ood-20230308
f8d98f11-a24c-48d9-baf1-a14ef9ce4590 ood-20230306
3b82817c-6c18-4132-b580-2e6ed1326d3d ood-20230304
8e0d1072-dd22-4e31-a992-bf153a14645a ood-20230303
5069b637-6aaf-418a-87d0-f89f0c30c6ab ood-20230301

It is deleting instance, but one instance a day. So it's confirmed. It's bash not saving subshell output as an array.

mentioned in merge request !42 (merged)

Verified the fix works: CI job 32100

$ SERVER_TO_BE_DELETE=($(openstack server list --name ood-knightly --sort-column Image --sort-descending -f value -c ID | sed -n $(($NUM_SERVER_TO_KEEP+1))',$p')) # collapsed multi-line command
server delete fffcd1c5-edd2-4dba-ab8a-2ba6e29b62a5
server delete 3f98e4e2-b71e-4617-883b-616b0d3f4870
server delete 4b031299-9d1b-4950-b748-964456d31da4
server delete f8d98f11-a24c-48d9-baf1-a14ef9ce4590
server delete 3b82817c-6c18-4132-b580-2e6ed1326d3d
server delete 8e0d1072-dd22-4e31-a992-bf153a14645a
server delete 5069b637-6aaf-418a-87d0-f89f0c30c6ab

mentioned in commit 5cc9fae5

closed with merge request !42 (merged)