Update main.tf

external-network/main.tf

-data "openstack_networking_network_v2" "public-network" {name = var.public-network-name}
-
-variable "admin-state-up" { }
+variable "admin_state_up" {default = "string" }
+variable "public_network_name" {default = "string" }
+variable "enable_dhcp" {default = "string"}
 variable "name" {default = "dmz"}
-variable "public-network-name" { }
 
+data "openstack_networking_network_v2" "public-network" {name = "bright-external-flat-externalnet"}
 
 # creates dmznet
 resource "openstack_networking_network_v2" "external_net" {
   name           = "${var.name}-net"
-  admin_state_up = var.admin-state-up
+  admin_state_up = var.admin_state_up
 }
 
 resource "openstack_networking_subnet_v2" "external_subnet" {
@@ -17,13 +17,13 @@ resource "openstack_networking_subnet_v2" "external_subnet" {
   cidr            = "192.168.100.0/24"
   ip_version      = 4
   dns_nameservers = ["8.8.8.8"]
-  enable_dhcp     = var.enable-dhcp
+  enable_dhcp     = var.enable_dhcp
 }
 
 # defines the router borderrouter using floating ip defined in datasources.tf to create the external network id
 resource "openstack_networking_router_v2" "router" {
   name                = "${var.name}-router"
-  admin_state_up      = var.admin-state-up
+  admin_state_up      = var.admin_state_up
   external_network_id = data.openstack_networking_network_v2.public-network.id
 }